Feat/settings flow by LeonardoVieira1630 · Pull Request #238 · blockful/notification-system

LeonardoVieira1630 · 2026-03-26T13:09:37Z

Summary

Add user notification preferences (settings) allowing users to choose which notification types they receive, and add support for offchain vote cast notifications. The settings flow is available via Telegram and Slack bots, backed by a new user_notification_preferences database table and API endpoints. The dispatcher now filters subscribers by triggerType so users only receive notifications they've opted into.

Changes

Notification Settings UI: Add /settings command and interactive settings flow for both Telegram (toggle grid) and Slack (checkbox list), built on a shared BaseSettingsService
Settings API & persistence: Add settings.controller, settings.handler, settings.service, and UserNotificationPreferences repository in subscription-server with GET and PUT endpoints
Database migration: Add user_notification_preferences table to store per-user trigger-type opt-in/out preferences
triggerType filtering: Extend getSubscribers, getDaoSubscribers, getWalletOwners, and batch methods across the dispatcher and subscription-client to propagate and filter by triggerType
Unique voting-reminder trigger IDs: Split voting reminder into distinct 30/60/90 trigger IDs for granular preference control
NOTIFICATION_TYPES constant: Add shared constant in the messages package mapping trigger IDs to user-facing labels
Offchain vote cast feature: Add offchain vote cast trigger, handler, message templates, and GraphQL query in anticapture-client
Onboarding update: Settings mention added to onboarding messages; learn_more_settings action now opens the settings flow
Tests: Add unit tests for settings service and preferences repository, integration tests for notification settings filtering and offchain vote cast trigger
Refactoring: Improve DAO confirm message, clean up and restructure existing tests to follow better patterns

Adds IUserNotificationPreferencesRepository interface and UserNotificationPreference entity to the interfaces file, then implements the repository with findByUser, upsertMany (insert-or-update via onConflict merge), and filterActiveUsers (missing row = enabled, only is_active=false rows are excluded). 13 unit tests cover all methods and edge cases with 100% statement/branch coverage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Implements GET and POST /users/by-channel/:channel/:channelUserId/notification-preferences endpoints with Zod schema validation, handler, and controller. Wires SettingsService and UserNotificationPreferencesRepository into the App bootstrap. Adds @notification-system/messages as a workspace dependency to fix the missing module error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add optional triggerType parameter to getDaoSubscribers across the service, handler, controller, and schema layers so callers can filter subscribers to only those who have the given notification type enabled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ration x3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

NewProposalTriggerHandler, NewOffchainProposalTriggerHandler, and ProposalFinishedTriggerHandler now pass their respective triggerType strings to getSubscribers, enabling per-user preference filtering. Updated all affected test assertions accordingly, and fixed a pre-existing test bug in offchain-vote-cast where buildExpectedMessage was missing the address placeholder substitution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Updated VoteConfirmationTriggerHandler, OffchainVoteCastTriggerHandler, and VotingPowerTriggerHandler to pass triggerType to all getWalletOwnersBatch, getSubscribers, and getDaoSubscribers calls, enabling per-notification-type preference filtering for hybrid handlers. Updated test expectation to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ng + VotingReminder handlers - Add optional `triggerType` param to `prepareBatchData` and forward it to `getWalletOwnersBatch` and `getDaoSubscribers` - Add `triggerType` as 3rd parameter to `sendBatchNotifications` (between `daoId` and `eventIdGenerator`) - NonVotingHandler passes `'non-voting'` as triggerType to `sendBatchNotifications` - VotingReminderTriggerHandler accepts `triggerType` in `processReminderEvent` and passes `message.triggerId` from `handleMessage` - Update test assertions to reflect new triggerType arguments Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add triggerType assertions to 4 handler test files (new-offchain-proposal, offchain-vote-cast, vote-confirmation, voting-power-changed) and create a NOTIFICATION_TYPES safety net test to ensure all dispatcher handler IDs have matching entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The subscription-server App constructor now requires settingsController, but the integration test setup was not passing it. Also added user_notification_preferences to the database cleanup list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel · 2026-03-26T13:09:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flow-editor	Ready	Preview, Comment	Mar 30, 2026 2:47pm
notification-system-dashboard	Ready	Preview, Comment	Mar 30, 2026 2:47pm

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

LeonardoVieira1630 · 2026-03-27T17:09:48Z

    windowSize: number = DEFAULT_WINDOW_SIZE
  ) {
-    super(TRIGGER_ID_PREFIX, interval);
+    super(`${TRIGGER_ID_PREFIX}-${thresholdPercentage}`, interval);


On the checkboxes, make sure that all the string is readable

LeonardoVieira1630 and others added 21 commits March 25, 2026 18:29

feat: add NOTIFICATION_TYPES constant to messages package

c8daf36

feat: unique trigger IDs for voting reminder thresholds (30/60/90)

77f8447

feat: add user_notification_preferences migration

63c2755

feat: add SettingsService for notification preferences

0e992de

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: extend getWalletOwners/batch with triggerType filtering

f072690

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: propagate triggerType through dispatcher subscription client

4e4abe4

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add triggerType to getSubscribers, split voting-reminder regist…

b577a8c

…ration x3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add notification preferences methods to SubscriptionAPIService

6abf15d

feat: add BaseSettingsService for notification preferences

33b15be

feat: add Telegram notification settings UI with toggle grid

4a086b0

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add Slack notification settings UI with checkbox list

653bd57

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add settings mentions to onboarding messages

8f123e9

test: add integration tests for notification settings filtering

5a6826b

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

LeonardoVieira1630 self-assigned this Mar 26, 2026

LeonardoVieira1630 added the feature label Mar 26, 2026

LeonardoVieira1630 changed the base branch from dev to feat/offchain-vote-cast-trigger March 26, 2026 13:10

remove: unnecessary test

c4d877e

vercel Bot deployed to Preview – notification-system-dashboard March 26, 2026 13:34 View deployment

vercel Bot deployed to Preview – flow-editor March 26, 2026 13:35 View deployment

remove: unnecessary test

82659a0

vercel Bot deployed to Preview – notification-system-dashboard March 26, 2026 13:39 View deployment

vercel Bot deployed to Preview – notification-system-dashboard March 26, 2026 14:09 View deployment

vercel Bot deployed to Preview – flow-editor March 26, 2026 14:09 View deployment

LeonardoVieira1630 marked this pull request as ready for review March 26, 2026 14:38

LeonardoVieira1630 requested review from PedroBinotto and pikonha March 26, 2026 14:40

LeonardoVieira1630 and others added 2 commits March 26, 2026 16:40

chore: add .worktrees/ to gitignore

ac87bda

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

refactor: broken test

48bf1a5

vercel Bot deployed to Preview – notification-system-dashboard March 26, 2026 19:51 View deployment

vercel Bot deployed to Preview – flow-editor March 26, 2026 19:51 View deployment

LeonardoVieira1630 commented Mar 27, 2026

View reviewed changes

Comment thread packages/messages/src/notification-types.ts Outdated

LeonardoVieira1630 commented Mar 27, 2026

View reviewed changes

Comment thread apps/dispatcher/src/services/triggers/base-trigger.service.ts Outdated

pikonha approved these changes Mar 27, 2026

View reviewed changes

refactor: NotificationTypeId

93c527c

vercel Bot deployed to Preview – notification-system-dashboard March 27, 2026 19:21 View deployment

vercel Bot deployed to Preview – flow-editor March 27, 2026 19:21 View deployment

LeonardoVieira1630 changed the base branch from feat/offchain-vote-cast-trigger to dev March 27, 2026 19:23

refactor: messages to be lower

eae3e6f

vercel Bot deployed to Preview – notification-system-dashboard March 27, 2026 19:36 View deployment

vercel Bot deployed to Preview – flow-editor March 27, 2026 19:37 View deployment

Merge branch 'dev' into feat/settings_flow

b780957

vercel Bot deployed to Preview – notification-system-dashboard March 30, 2026 14:08 View deployment

vercel Bot deployed to Preview – flow-editor March 30, 2026 14:08 View deployment

fix: broken tests

c5015da

vercel Bot deployed to Preview – notification-system-dashboard March 30, 2026 14:35 View deployment

vercel Bot deployed to Preview – flow-editor March 30, 2026 14:35 View deployment

add: OffchainProposalFinished where it is needed

51ce62c

LeonardoVieira1630 merged commit fda55bc into dev Mar 30, 2026
5 of 7 checks passed

vercel Bot deployed to Preview – notification-system-dashboard March 30, 2026 14:47 View deployment

vercel Bot deployed to Preview – flow-editor March 30, 2026 14:47 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/settings flow#238

Feat/settings flow#238
LeonardoVieira1630 merged 34 commits into
devfrom
feat/settings_flow

LeonardoVieira1630 commented Mar 26, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

LeonardoVieira1630 Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LeonardoVieira1630 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

vercel Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

LeonardoVieira1630 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LeonardoVieira1630 commented Mar 26, 2026 •

edited

Loading

vercel Bot commented Mar 26, 2026 •

edited

Loading